remove setup.py and migrate to a static pyproject.toml
#388
Conversation
| # What follows is an exact copy of the runtime dependencies, because (A) | ||
| # incremental needs to be able to import `treq` to be able to import | ||
| # `treq.__version__` (see `tools.setuptools.dynamic` below), and (B) the | ||
| # `treq` module is set up such that everything is eagerly imported into the | ||
| # top-level namespace and thus sucks in every other dependency that we | ||
| # require. |
There was a problem hiding this comment.
This is odd, because incremental exec()s the _version.py directly by my reading.
| [tool.setuptools.dynamic] | ||
| version = {attr = "treq.__version__"} |
There was a problem hiding this comment.
Oh, I see, you've tried to use setuptools attr and it's falling back to importing the module.
I don't see anything here equivalent to the use_incremental=True argument to setup(). It looks like we need to add support to incremental for direct integration with setuptools, like setuptools_scm has:
There was a problem hiding this comment.
Filed twisted/incremental#90 for this so that we can fix it in incremental. Sad that this seems to be the main setuptools build extension entrypoint.
|
@glyph Do you have any plan to revive this now that Incremental supports |
Thanks for the heads up, I would definitely like for this to be landed. |
Remove
setup.pyand migrate project metadata to a staticpyproject.toml.