Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

change the bookieServer cmdline to make conf-file and option co-exist #5

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jiazhai
Copy link

@jiazhai jiazhai commented Nov 4, 2016

Currently, when using bookieServer cmdline to start a bookie, you will either give it a cofiguration file by "-c booke.conf"; or add some options like "<bookie_port> <zk_servers> <journal_dir> <ledger_dir [ledger_dir]>" in a fix sequential.
It may not satisfy some of the requirement. So changed it to be co-exist for configuration file and options.

By this change, it will first use settings in configuration file; and then use options to overwrite some of the settings, if there are some options provided.

Here is an example after this change:
BookieServer -c bookie.conf -z localhost:2181 -m /bookkeeper/ledgers -p 3181 -j /mnt/journal -l "/mnt/ledger1 /mnt/ledger2 /mnt/ledger3”
Here, in this command:
-z is for “Zookeeper client instance”;
-m is for "Zookeeper ledgers root path for bookies";
-p is for "bookie service port exported";
-j is for "bookie journal directory";
-l is for "bookie ledgers directories".

@sijie
Copy link
Contributor

sijie commented Nov 9, 2016

@jiazhai looks good to me.

@jiazhai
Copy link
Author

jiazhai commented Nov 9, 2016

@sijie Thanks for the review, looking forward to be merged.

arvindkandhare pushed a commit to arvindkandhare/bookkeeper that referenced this pull request Mar 17, 2017
…ry log file

sijie I've addressed all comments from https://reviews.apache.org/r/33061

Author: Matteo Merli <[email protected]>

Reviewers: Sijie Guo <[email protected]>

Closes twitter-archive#5 from merlimat/bk-841
@CLAassistant
Copy link

CLAassistant commented Jul 29, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ Jia Zhai
❌ jiazhai


Jia Zhai seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants