This repository has been archived by the owner on Oct 5, 2019. It is now read-only.
FIX : Return YES if the SSO login isMobileSSOSuccess #109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I was not able to properly finalize a login with a Twitter account using Firebase. The Twitter login is actually impossible to enable with the FirebaseUI auth providers.
I noticed an error in your management of OpenUrl in the application delegate
Solution
Say YES when TwitterKit is challenged to open an URL and the SSO is a success. TwitterKit has done the job!
Result
Avoid a crash on the providers loop on the Firebase UI SDK because the SDK will try to find a provider to handle the asked openUrl and your SDK has complete the job 👍