Skip to content

Commit

Permalink
scrooge-sbt-plugin: Clarify default for scroogeThriftOutputFolder
Browse files Browse the repository at this point in the history
Summary: Problem

The explanation for the default value of scroogeThriftOutputFolder is out of date. The default output is now sourceManaged/thrift.

The output of git diff scrooge-4.7.0 -- src/main/scala/com/twitter/ScroogeSBT.scala shows, in part, this:

```
-    scroogeThriftOutputFolder <<= (sourceManaged) { identity },
+    scroogeThriftOutputFolder in Compile := (sourceManaged in Compile).value / "thrift",
+    scroogeThriftOutputFolder in Test := (sourceManaged in Test).value / "thrift",
```

Signed-off-by: Moses Nakamura <[email protected]>

Differential Revision: https://phabricator.twitter.biz/D144011
  • Loading branch information
Aaron Niskode-Dossett authored and jenkins committed Mar 6, 2018
1 parent 4e5538e commit 792fd68
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion doc/src/sphinx/SBTPlugin.rst
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ most likely to want to edit:
- **scroogeThriftOutputFolder: File**

where to put the generated scala files
(default: `target/<scala-ver>/src_managed`)
(default: `target/<scala-ver>/src_managed/thrift`)


Migrating from 3.x.x to 3.18.0
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ object ScroogeSBT extends AutoPlugin {

val scroogeThriftOutputFolder = SettingKey[File](
"scrooge-thrift-output-folder",
"output folder for generated files (defaults to sourceManaged)"
"output folder for generated files (defaults to sourceManaged/thrift)"
)

val scroogeIsDirty = TaskKey[Boolean](
Expand Down

0 comments on commit 792fd68

Please sign in to comment.