Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix admin authorization on recent Etherpad #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix admin authorization on recent Etherpad #47

wants to merge 1 commit into from

Commits on Apr 12, 2021

  1. Fix admin authorization on recent Etherpad 

    As of Etherpad 1.8.7 (and possibly earlier), the authorize hook did not
seem to be called anymore. According to the documentation, it is not
called for admin paths, and recent Etherpads allow admin access only to
admin users anyway.
Thus, this commit moves the admin check to be part of authentication.
This has the disadvantage that admin sessions will stay valid even if a
user is removed from an admin group, which is now documented in the
README.

Signed-off-by: pcworld <[email protected]>
    @pcworld
    pcworld committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    c8e2d95 View commit details
    Browse the repository at this point in the history