some methods marked private in channel are not private in practice

tylerbarker · May 12, 2024 · f8ae70f · f8ae70f
1 parent 035b56c
commit f8ae70f
Showing 1 changed file with 24 additions and 33 deletions.
diff --git a/phoenix/channel.js b/phoenix/channel.js
@@ -286,6 +286,30 @@ export default class Channel {
     return payload;
   }
 
+  joinRef() {
+    return this.joinPush.ref;
+  }
+
+  trigger(event, payload, ref, joinRef) {
+    let handledPayload = this.onMessage(event, payload, ref, joinRef);
+    if (payload && !handledPayload) {
+      throw new Error(
+        "channel onMessage callbacks must return the payload, modified or unmodified",
+      );
+    }
+
+    let eventBindings = this.bindings.filter((bind) => bind.event === event);
+
+    for (let i = 0; i < eventBindings.length; i++) {
+      let bind = eventBindings[i];
+      bind.callback(handledPayload, ref, joinRef || this.joinRef());
+    }
+  }
+
+  replyEventName(ref) {
+    return `chan_reply_${ref}`;
+  }
+
   /**
    * @private
    */
@@ -308,13 +332,6 @@ export default class Channel {
     }
   }
 
-  /**
-   * @private
-   */
-  joinRef() {
-    return this.joinPush.ref;
-  }
-
   /**
    * @private
    */
@@ -327,32 +344,6 @@ export default class Channel {
     this.joinPush.resend(timeout);
   }
 
-  /**
-   * @private
-   */
-  trigger(event, payload, ref, joinRef) {
-    let handledPayload = this.onMessage(event, payload, ref, joinRef);
-    if (payload && !handledPayload) {
-      throw new Error(
-        "channel onMessage callbacks must return the payload, modified or unmodified",
-      );
-    }
-
-    let eventBindings = this.bindings.filter((bind) => bind.event === event);
-
-    for (let i = 0; i < eventBindings.length; i++) {
-      let bind = eventBindings[i];
-      bind.callback(handledPayload, ref, joinRef || this.joinRef());
-    }
-  }
-
-  /**
-   * @private
-   */
-  replyEventName(ref) {
-    return `chan_reply_${ref}`;
-  }
-
   /**
    * @private
    */