Improve Node.js server shutdown and error handling #2554
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some minor tweaking to make the code a bit nicer.
More importantly, I think this suffers from same/similar problems as #2300, namely: how do you gracefully shutdown/handle errors? The critical thing seems to be that any sockets remaining in the queue should be destroyed.
Perhaps I'm missing something, but it seems to me that the problem lies with the
server
method. With theserverResource
method, I can conceptualize the "listening" part of the server being tied to the resource, so that even after the resource is closed the stream of sockets is still usable. But maybe this is leaky?cc @RaasAhsan