Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accumulating variant of Stream.debounce #3028

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

m50d
Copy link

@m50d m50d commented Oct 27, 2022

I don't know if there's enough demand/need for this, but I had a use case where I needed something like debounce but that keeps all the elements of the stream, and it seemed generic enough to be worth sharing.

@m50d
Copy link
Author

m50d commented Oct 27, 2022

Appreciate there were a number of failures that were my fault, but I can't understand the latest one (native linking failure) - what's the issue here?

@armanbilge
Copy link
Member

Just a flake :)

@mpilquist
Copy link
Member

Any thoughts on NonEmptyChain versus Chunk here?

@m50d
Copy link
Author

m50d commented Nov 20, 2022

It wasn't a particularly thought-through choice, just the type I reached for. For my specific use case a type that expresses that it's always non-empty is helpful, but happy to switch it to Chunk if you think that's more useful in the general case.

@mpilquist
Copy link
Member

OK cool, I think we should switch to Chunk then. There are lots of APIs that would benefit from a NonEmptyChunk indication, though we tried that for a while and it didn't end up working out that well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants