Relax constraint for Signal.constant
#3032
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SystemFw
reviewed
Nov 3, 2022
There was a problem hiding this comment.
A bit unsure if this is of any value. The Concurrent constraint is everywhere in fs2, and I don't see the difference between Spawn and Concurrent to be that meaningful for users. I can see how Temporal vs Concurrent might help, but not really this one. Open to changing my mind ofc
|
FWIW I completely agree, I doubt this would make a difference for anyone. Certainly not to me. Was this |
|
@armanbilge If you fix PR, happy to merge it if you still think it of use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.