Use CE polling system for non-blocking I/O on Native #3087
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Lee Tibbert <[email protected]>
|
Tests are passing locally on both Linux and macOS (will need to add this to CI going forward). Published |
This was referenced Dec 23, 2022
|
TODO need to port this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adopts the new polling system APIs from typelevel/cats-effect#3314 to implement non-blocking TCP/unix sockets and stdin/stdout/stderr for Scala Native. This means that epollcat is no longer required: everything now works out of the box with
IOAppand the defaultIORuntime.Much of the code was cribbed from epollcat and fs2-io_uring (with thanks to @LeeTibbert). Some of it can be upstreamed to ip4s or even completely removed when we upgrade to Scala Native 0.5.
This PR is tangled up with the new uncancelable semantics in CE 3.5 so it will need #3063 to merge first. It also needs a Scala Native release with scala-native/scala-native#3015 which will also unblock
DatagramSocket.