Use Vector instead of List

typelevel · Dec 7, 2023 · a14d318 · a14d318
1 parent 43d4783
commit a14d318
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 25 deletions.
diff --git a/sdk/trace/src/main/scala/org/typelevel/otel4s/sdk/trace/SdkSpanBackend.scala b/sdk/trace/src/main/scala/org/typelevel/otel4s/sdk/trace/SdkSpanBackend.scala
@@ -258,7 +258,7 @@ private[trace] object SdkSpanBackend {
       parentContext: Option[SpanContext],
       processor: SpanProcessor[F],
       attributes: Attributes,
-      links: List[LinkData],
+      links: Vector[LinkData],
       userStartTimestamp: Option[FiniteDuration]
   ): F[SdkSpanBackend[F]] = {
     def immutableState(startTimestamp: FiniteDuration) =
@@ -276,7 +276,7 @@ private[trace] object SdkSpanBackend {
       name = name,
       status = StatusData.Unset,
       attributes = attributes,
-      events = Nil,
+      events = Vector.empty,
       endTimestamp = None
     )
 
@@ -294,7 +294,7 @@ private[trace] object SdkSpanBackend {
       kind: SpanKind,
       parentContext: Option[SpanContext],
       resource: Resource,
-      links: List[LinkData],
+      links: Vector[LinkData],
       startTimestamp: FiniteDuration
   )
 
@@ -304,7 +304,7 @@ private[trace] object SdkSpanBackend {
       name: String,
       status: StatusData,
       attributes: Attributes,
-      events: List[EventData],
+      events: Vector[EventData],
       endTimestamp: Option[FiniteDuration]
   )
 

diff --git a/sdk/trace/src/main/scala/org/typelevel/otel4s/sdk/trace/data/SpanData.scala b/sdk/trace/src/main/scala/org/typelevel/otel4s/sdk/trace/data/SpanData.scala
@@ -70,11 +70,11 @@ sealed trait SpanData {
 
   /** The events associated with the span.
     */
-  def events: List[EventData]
+  def events: Vector[EventData]
 
   /** The links associated with the span.
     */
-  def links: List[LinkData]
+  def links: Vector[LinkData]
 
   /** The instrumentation scope associated with the span.
     */
@@ -151,8 +151,8 @@ object SpanData {
       endTimestamp: Option[FiniteDuration],
       status: StatusData,
       attributes: Attributes,
-      events: List[EventData],
-      links: List[LinkData],
+      events: Vector[EventData],
+      links: Vector[LinkData],
       instrumentationScope: InstrumentationScope,
       resource: Resource
   ): SpanData =
@@ -219,8 +219,8 @@ object SpanData {
       endTimestamp: Option[FiniteDuration],
       status: StatusData,
       attributes: Attributes,
-      events: List[EventData],
-      links: List[LinkData],
+      events: Vector[EventData],
+      links: Vector[LinkData],
       instrumentationScope: InstrumentationScope,
       resource: Resource
   ) extends SpanData

diff --git a/sdk/trace/src/test/scala/org/typelevel/otel4s/sdk/trace/Cogens.scala b/sdk/trace/src/test/scala/org/typelevel/otel4s/sdk/trace/Cogens.scala
@@ -137,8 +137,8 @@ object Cogens {
         Option[FiniteDuration],
         StatusData,
         Attributes,
-        List[EventData],
-        List[LinkData],
+        Vector[EventData],
+        Vector[LinkData],
         InstrumentationScope,
         Resource
     )

diff --git a/sdk/trace/src/test/scala/org/typelevel/otel4s/sdk/trace/Gens.scala b/sdk/trace/src/test/scala/org/typelevel/otel4s/sdk/trace/Gens.scala
@@ -177,8 +177,8 @@ object Gens {
       endEpochNanos,
       status,
       attributes,
-      events,
-      links,
+      events.toVector,
+      links.toVector,
       instrumentationScope,
       resource
     )

diff --git a/sdk/trace/src/test/scala/org/typelevel/otel4s/sdk/trace/SdkSpanBackendSuite.scala b/sdk/trace/src/test/scala/org/typelevel/otel4s/sdk/trace/SdkSpanBackendSuite.scala
@@ -82,9 +82,9 @@ class SdkSpanBackendSuite extends CatsEffectSuite with ScalaCheckEffectSuite {
       TestControl.executeEmbed {
         for {
           span <- start()
-          _ <- assertIO(span.toSpanData.map(_.events), Nil)
+          _ <- assertIO(span.toSpanData.map(_.events), Vector.empty)
           _ <- span.addEvent(name, attributes.toList: _*)
-          _ <- assertIO(span.toSpanData.map(_.events), List(event))
+          _ <- assertIO(span.toSpanData.map(_.events), Vector(event))
         } yield ()
       }
     }
@@ -97,9 +97,9 @@ class SdkSpanBackendSuite extends CatsEffectSuite with ScalaCheckEffectSuite {
       TestControl.executeEmbed {
         for {
           span <- start()
-          _ <- assertIO(span.toSpanData.map(_.events), Nil)
+          _ <- assertIO(span.toSpanData.map(_.events), Vector.empty)
           _ <- span.addEvent(name, ts, attrs.toList: _*)
-          _ <- assertIO(span.toSpanData.map(_.events), List(event))
+          _ <- assertIO(span.toSpanData.map(_.events), Vector(event))
         } yield ()
       }
     }
@@ -129,9 +129,9 @@ class SdkSpanBackendSuite extends CatsEffectSuite with ScalaCheckEffectSuite {
       TestControl.executeEmbed {
         for {
           span <- start()
-          _ <- assertIO(span.toSpanData.map(_.events), Nil)
+          _ <- assertIO(span.toSpanData.map(_.events), Vector.empty)
           _ <- span.recordException(exception, attributes.toList: _*)
-          _ <- assertIO(span.toSpanData.map(_.events), List(event))
+          _ <- assertIO(span.toSpanData.map(_.events), Vector(event))
         } yield ()
       }
     }
@@ -303,7 +303,7 @@ class SdkSpanBackendSuite extends CatsEffectSuite with ScalaCheckEffectSuite {
           kind: SpanKind,
           parentCtx: Option[SpanContext],
           attributes: Attributes,
-          links: List[LinkData],
+          links: Vector[LinkData],
           userStartTimestamp: Option[FiniteDuration]
       ) =>
         def expected(end: Option[FiniteDuration]) =
@@ -316,7 +316,7 @@ class SdkSpanBackendSuite extends CatsEffectSuite with ScalaCheckEffectSuite {
             endTimestamp = end,
             status = StatusData.Unset,
             attributes = attributes,
-            events = Nil,
+            events = Vector.empty,
             links = links,
             instrumentationScope = scope,
             resource = Defaults.resource
@@ -385,8 +385,8 @@ class SdkSpanBackendSuite extends CatsEffectSuite with ScalaCheckEffectSuite {
           endTimestamp = end,
           status = StatusData.Unset,
           attributes = Defaults.attributes,
-          events = Nil,
-          links = Nil,
+          events = Vector.empty,
+          links = Vector.empty,
           instrumentationScope = Defaults.scope,
           resource = Defaults.resource
         )
@@ -445,7 +445,7 @@ class SdkSpanBackendSuite extends CatsEffectSuite with ScalaCheckEffectSuite {
       parentSpanContext: Option[SpanContext] = None,
       attributes: Attributes = Defaults.attributes,
       spanProcessor: SpanProcessor[IO] = Defaults.spanProcessor,
-      links: List[LinkData] = Nil,
+      links: Vector[LinkData] = Vector.empty,
       userStartTimestamp: Option[FiniteDuration] = None
   ): IO[SdkSpanBackend[IO]] = {
     SdkSpanBackend.start[IO](