Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tracer#currentSpanOrNoop #349

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Add Tracer#currentSpanOrNoop #349

merged 1 commit into from
Nov 7, 2023

Conversation

NthPortal
Copy link
Contributor

@NthPortal NthPortal commented Oct 27, 2023 •
edited
Loading

Follow-up/resolution to #101.

  • tests
  • rebase -i --autosquash

@NthPortal NthPortal added the tracing Improvements to tracing module label Oct 27, 2023
iRevive
iRevive approved these changes Oct 28, 2023
View reviewed changes
Copy link
Contributor

@iRevive iRevive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@iRevive iRevive added this to the 0.3 milestone Oct 28, 2023
@iRevive iRevive merged commit b5ba469 into typelevel:main Nov 7, 2023
10 checks passed
@NthPortal NthPortal deleted the current-span/PR branch November 8, 2023 08:08
@NthPortal NthPortal mentioned this pull request Nov 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iRevive iRevive iRevive approved these changes

@armanbilge armanbilge Awaiting requested review from armanbilge

Assignees
No one assigned
Labels
tracing Improvements to tracing module
Projects
None yet
Milestone
0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@NthPortal @iRevive