Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site: add Tracing instrumentation page #352

Merged
merged 2 commits into from
Nov 4, 2023

Conversation

iRevive
Copy link
Contributor

@iRevive iRevive commented Oct 31, 2023

No description provided.

@iRevive iRevive added the documentation Improvements or additions to documentation label Oct 31, 2023
@iRevive iRevive force-pushed the docs/tracing-instrumentation branch from 38f6e5f to 0f76050 Compare October 31, 2023 19:11
Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly insignificant comments inline.

import org.typelevel.otel4s.java.OtelJava

OtelJava.global.flatMap { otel4s =>
otel4s.tracerProvider.get("com.service").flatMap { implicit tracer: Tracer[IO] =>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is supposed to be a domain name, I'd use com.example.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about the package.

Let's say you keep your code under the "com.mycompany.internal.api" package. So, you can use this name with a tracer.

docs/instrumentation/tracing.md Outdated Show resolved Hide resolved
Co-authored-by: Ross A. Baker <[email protected]>
@iRevive iRevive merged commit fe8293f into typelevel:main Nov 4, 2023
10 checks passed
@iRevive iRevive deleted the docs/tracing-instrumentation branch November 4, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants