Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin to ubuntu-22.04 as default runner OS #762

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

samspills
Copy link
Contributor

This week we saw a lot of chaos because the ubuntu-latest runner tag was switched to the ubuntu-24.04 image, away from the ubuntu-22.04 image1.

I'm proposing that we pin the ubuntu runner OS to 22.04 as the default value so we can avoid that chaos in the future. By pinning we can

  • test here before updating to a new runner tag, preventing CI for sbt-typelevel users from breaking unexpectedly (breaking due to this kind of change at least lol)
  • communicate with users via a major release + release notes if a major change like this happens again

Footnotes

  1. And that switch is now being rolled back for the time being 😵

@samspills samspills self-assigned this Oct 16, 2024
@valencik
Copy link
Member

Doing this would also save us an extra character width in the job names!
re: #761

@samspills samspills mentioned this pull request Oct 17, 2024
@armanbilge
Copy link
Member

👍 to pinning. Why go back to 22.04 / when should we go to 24.04 given that things are working now (I think 😅). I guess we can wait until GH makes 24.04 latest again, as a sign of stability? idk.

@samspills
Copy link
Contributor Author

samspills commented Oct 17, 2024

Why go back to 22.04 / when should we go to 24.04 given that things are working now (I think 😅). I guess we can wait until GH makes 24.04 latest again, as a sign of stability? idk.

I had the same thinking/question. I chose 22.04 so it would match the current behaviour of latest just in case, but it's not a strongly held opinion.
Edit: and then yeah, I agree with moving to 24.04 when the latest change rolls out again (hoping we actually get told it happens etc.)

@armanbilge armanbilge merged commit 885eb22 into typelevel:main Oct 17, 2024
15 checks passed
@samspills samspills deleted the sam/pin-ubuntu-runner branch October 17, 2024 17:35
@armanbilge
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants