Support editor-translator term
#13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes typst/hayagriva#187 (and therefore should fix hayagriva's CI)
Right now, I'm just considering
editor-translatorandeditortranslatorto represent the same thing: a term that is used when the editor and the translator are the same in a CSL<names>.At the time of writing, the only official styles in https://github.com/citation-style-language/styles that appear to be using this term are APA styles, which define
editortranslatorandeditor-translatorto be the same. Other styles are still using onlyeditortranslator.It is theoretically possible for the two terms to have separate definitions in a locale, so maybe this PR's approach of expecting both to be the same could be too naive. However, it's still an improvement over the status quo - currently, APA styles fail to parse with a rather obtuse error (
Custom("data did not match any variant of untagged enum Term")). Regardless, we could consider creating a separate term variant, e.g.EditorTranslatorOldfor"editortranslator"andEditorTranslatorfor"editor-translator".