Parse page ranges following citeproc #155
Conversation
|
I have fixed the compile error and removed the provisional error message. I noticed that there were a few test regressions:
❌ Test label_EmptyLabelVanish should pass but failed
❌ Test locale_PageRangeDelimiterTermDefined should pass but failed ❌ Test locale_PageRangeDelimiterTermFrenchUndef should pass but failed ❌ Test number_PageFirst should pass but failed ❌ Test number_StrangeError should pass but failed ❌ Test page_Chicago should pass but failed ❌ Test page_Chicago16 should pass but failed ❌ Test page_NumberPageFirst should pass but failed ❌ Test page_PluralDetectWithEndash should pass but failed ❌ Test page_WithLocaleAndWeirdDelimiter should pass but failed ❌ Test virtual_PageFirst should pass but failed citeproc regressionsChicago, for example, seems to be reversed in terms of what numbers it omits. It would be great if you could check what's going wrong here and if there's a common cause! |
|
There was a minor bug in the page range formats for citationberg that I fixed. Besides that I put Look into the design changes, especially for citationberg, and let me know if you want something changed. |
|
I merged typst/citationberg#14 with two comments added, thank you!
|
|
From my POV this is good to merge. There might be further work down the line but this is worth an update imo |
| if let NumberOrPageVariable::Number(v) = label.variable { | ||
| n.is_plural(v.is_number_of_variable()) | ||
| } else { | ||
| panic!("Incompatiable variable types") | ||
| } |
There was a problem hiding this comment.
It would be nice to enforce this on a type system level but it's okay for now
This PR depends on typst/citationberg#7.
Allows for
page-rangefield to have multiple ranges, as in1-4 & 7-12, 13, 14\-19.Each of these is split into parts:
,&1314\-19, where the hyphen will not be replaced by the given separator1-4Ranges are given to citationberg to format depending on the format rule per the CSL spec.