Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncku-later:0.1.0 #1542

Closed
wants to merge 9 commits into from
Closed

ncku-later:0.1.0 #1542

wants to merge 9 commits into from

Conversation

Haouo
Copy link

@Haouo Haouo commented Jan 10, 2025

I am submitting

  • a new package
  • an update for a package

Description: This is a template for writing master thesis or doctoral dissertation in National Cheng Kung University, Taiwan.

I have read and followed the submission guidelines and, in particular, I

  • selected a name that isn't the most obvious or canonical name for what the package does
  • added a typst.toml file with all required keys
  • added a README.md with documentation for my package
  • have chosen a license and added a LICENSE file or linked one in my README.md
  • tested my package locally on my system and it worked
  • excluded PDFs or README images, if any, but not the LICENSE
  • ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

@typst-package-check typst-package-check bot added the new A new package submission. label Jan 10, 2025
@Haouo Haouo marked this pull request as ready for review January 10, 2025 11:24
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have the rights to distribute this image? If not, could you please replace it with another one under a permissive license (and add a note about this license in your README or LICENSE file).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh... I am sorry about that, I think you are right I should not use this image. I will replace it with my own image later

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elegaanz I have changed the image to the Linux logo, and it seems like the Liinux logo image can be used freely on the internet.

@@ -0,0 +1,17 @@
[package]
name = "ncku-thesis-template"
Copy link
Member

@elegaanz elegaanz Jan 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please rename your package? The template part is redundant in my opinion. But more importantly, unless this is an official template, the name of your package should include some distinctive component, so that is not the canonical name for what your package does. You can try to make a pun, or add an adjective to the current name, for example.
If this package is officially endorsed by the university, a member of the staff should send an email stating so to [email protected].

@typst-package-check typst-package-check bot changed the title ncku-thesis-template:0.1.0 ncku-later:0.1.0 and ncku-thesis-template:0.1.0 Jan 12, 2025
@Haouo Haouo changed the title ncku-later:0.1.0 and ncku-thesis-template:0.1.0 ncku-later:0.1.0 Jan 12, 2025
@Haouo Haouo closed this Jan 12, 2025
@Haouo Haouo deleted the ncku-thesis-template-0.1.0 branch January 12, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new A new package submission.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants