Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#149 Raw data storing format is added #150

Conversation

nadeyamalashevich
Copy link

Fix for the issue #149: Option to store/return raw value for dropdown.

@Hendy
Copy link
Contributor

Hendy commented Mar 6, 2017

Hi @nadeyamalashevich Thanks for this PR :)
Yes, makes sense to pass the SaveFormat about rather than guess the type by the data 👍
I think the Raw option should only be available when it's a picker configured to select a single item (I know the TypeaheadList picker does something similar to restrict the CSV format)

@Hendy
Copy link
Contributor

Hendy commented Mar 6, 2017

arh, guessing the save format from the data has the advantage of allowing the save format to be changed, and it'll still read in old saved data

@Hendy
Copy link
Contributor

Hendy commented Apr 4, 2017

closing, as fixing #59 / #149 should resolve this

@Hendy Hendy closed this Apr 4, 2017
@nadeyamalashevich nadeyamalashevich deleted the issue#149-raw-dropdown-value branch June 5, 2017 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants