Fix issue where csv data could be lost #182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user presses save/publish quickly it is possible to lose the picker value when using csv. This fix preloads the list with the csv values so they are not lost. This issue is most likely to occur when the list stores a long list of values.
|
Awesome, thanks for this |
|
Hi, sorry for a late reply, yes this is an issue if a page is saved before all ajax calls have completed. Good idea about loading labels ! however I don't think this fully fixes the issue as it assumes the value is a csv - the string chop could do weird things to the other formats, making weird keys, which then saved at the 'wrong time'... It's probably better handled in the EditorResource.js as all the pickers could do with this fix, will investigate as this does need fixing. Thanks |
|
Closing as this PR as issue #179 needs to be fixed for all save formats |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user presses save/publish quickly it is possible to lose the
picker value when using csv. This fix preloads the list with the csv
values so they are not lost. This issue is most likely to occur when the
list stores a long list of values.