Use dependencies for yaml files from uap-core

[douglaspalmer]

We would like to use uap-java in the keycloak project (https://www.keycloak.org). However, to do so I need to make a change to your build system. Would my proposed changes be acceptable to you?

[bpossolo]

why is this all commented out?

[douglaspalmer]

Sorry, commented it out to see if unpacking was necessary. It wasn't so I will delete it and update the pull request.

[bpossolo]

i think this change makes sense.
i always thought the <resource> blocks with references to {baseDir} kind of odd and unconventional for maven

[abstractj]

@bpossolo do you think we can get it in further releases? Is there anything missing?

[ThoSap]

@bpossolo when will this be merged into master?
This would be awesome and very much appreciated by the community! 🚀🤩

[bpossolo]

Ok. I’ll merge and just note that we should remove the git module reference to the other project

[bpossolo]

I just gave this PR a spin and it doesn't work.

There is no artifact in Maven central that matches:

• group id: com.github.ua-parser
• artifact id: uap-core

I presume this was never tested or you created the artifact yourself and installed it in your local Maven repo so I'm going to revert.

[douglaspalmer]

The PR is well tested and works; you just need to apply the other half: ua-parser/uap-core#348

[bpossolo]

Oh I see. It would have been good to link this PR to that one and made clear there was a dependency on that.

I don't have control of uap-core... so it will require that to be done first.

[bpossolo]

Out of curiosity, can you explain what is preventing you from using the uap-java artifact directly which includes the regexp yaml files?

[douglaspalmer]

Out of curiosity, can you explain what is preventing you from using the uap-java artifact directly which includes the regexp yaml files?

For my use case; we build everything from source internally. We don't use external binaries.

[bpossolo]

Ok, I thought that might be that case.
Are you aware that the Parser class has a constructor which accepts an InputStream to the regexp file?
In the meantime, can you get the uap-core repo + it's yaml file then use that constructor instead?

I presume the maven tests will all fail without uap-core where it's expected to be so you might need to add -Dmaven.test.skip=true when building the artfiact.

[bpossolo]

I commented in the other PR asking @commenthol for advice.
I can't just merge your PR into his project as I don't really consider myself a maintainer for that.

If I remember correctly, I'll need to go through all the steps to get a new artifact published to Maven Central which requires some time as it's a bit of a manual back-and-forth process.