Feature/remove original file data #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jupiter will no longer be serving original_file data so the tests need to be changed to reflect this. This current change applies to test run locally, the next step is not make them run in CI.
Tests were using multiple ```let``` calls. Should come back to this at a later date if needed.
…talib/pushmi_pullyu into feature/remove_original_file_data
lagoan
requested review from
ConnorSheremeta,
mbarnett,
murny,
pgwillia and
piyapongch
as code owners
Generated by 🚫 Danger |
1 similar comment
Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Jupiter will no longer be serving original_file data as part of the AIP API so PushmiPullyu now needs to change its behavior to accommodate this.
Related to #196
What's New
Remove references of original_file from logic in
lib/pushmi_pullyu/aip/downloader.rb, the rest of the changes have to do with fixing tests. The PR has a lot of modified files but most of them are fixtures that do not change the logic of the tests.