Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CHANGELOG and VERSION for 2.1.4 release #483

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

pgwillia
Copy link
Member

@pgwillia pgwillia commented Oct 8, 2024

Context

Prepare for 2.1.4 release

What's New

Updated CHANGELOG and version.rb version.

CHANGELOG.md Outdated
### Added
- Bring in and enforce inclusive language cops [PR#469](https://github.com/ualbertalib/pushmi_pullyu/pull/469)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There looks like an extra blank space character here?

@@ -246,4 +246,4 @@ DEPENDENCIES
webmock (~> 3.24)

BUNDLED WITH
2.3.12
2.4.9
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any advantage to using the same bundler version as jupiter?

https://github.com/ualbertalib/jupiter/blob/caaa54e6932afd8c3c1a92b3a1a26eb6ee4d8b94/Gemfile.lock#L708

   2.5.6

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no versions of bundler (= 2.5.6) compatible with your Ruby & RubyGems
        bundler requires Ruby version >= 3.0.0. The current ruby version is 2.7.6.219.

I can see what might be required to bump the Ruby version, but I'll leave the bundler version and add a call out to the bundle version change in the Changelog.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can figure out how to depend on @lagoan's fork then bumping Ruby might be possible. #251 (comment)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me.

@pgwillia pgwillia changed the title Bump CHANGELOG and VERSION for 2.0.2 release Bump CHANGELOG and VERSION for 2.1.4 release Oct 10, 2024
Also bump bundler and update changelog.
Copy link

@jefferya jefferya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -246,4 +246,4 @@ DEPENDENCIES
webmock (~> 3.24)

BUNDLED WITH
2.3.12
2.4.9

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me.

@pgwillia pgwillia merged commit 9eaeb9a into main Oct 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants