-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump CHANGELOG and VERSION for 2.1.4 release #483
Conversation
CHANGELOG.md
Outdated
### Added | ||
- Bring in and enforce inclusive language cops [PR#469](https://github.com/ualbertalib/pushmi_pullyu/pull/469) | ||
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There looks like an extra blank space character here?
@@ -246,4 +246,4 @@ DEPENDENCIES | |||
webmock (~> 3.24) | |||
|
|||
BUNDLED WITH | |||
2.3.12 | |||
2.4.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any advantage to using the same bundler version as jupiter?
2.5.6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no versions of bundler (= 2.5.6) compatible with your Ruby & RubyGems
bundler requires Ruby version >= 3.0.0. The current ruby version is 2.7.6.219.
I can see what might be required to bump the Ruby version, but I'll leave the bundler version and add a call out to the bundle version change in the Changelog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we can figure out how to depend on @lagoan's fork then bumping Ruby might be possible. #251 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me.
Also bump bundler and update changelog.
7f43663
to
66d16e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -246,4 +246,4 @@ DEPENDENCIES | |||
webmock (~> 3.24) | |||
|
|||
BUNDLED WITH | |||
2.3.12 | |||
2.4.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me.
Context
Prepare for 2.1.4 release
What's New
Updated CHANGELOG and version.rb version.