-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Pino logs #46
Adding Pino logs #46
Conversation
@yehee i added something to the Dockerfile if you want to take a look, in case you were wondering why i requested you LOL. |
Co-authored-by: Robert Lin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall!
@johnagl Bumped into this issue just now, has this been resolved? |
Changes
process.env.NODE_ENV === "development"
under
/server
no-console
rule to trueRUN
field in Dockerfile to install Chromium. this was a bug i didn't catch when we first started using Dockernodemon
on the scraper would cause infinite restartsconsole
statements to use the logger insteadunder
/client
no-console
rule to trueMotivation and Context
having logs instead of using
console.log
allows us to debug with richer information. with pino, we can potentially filter logs by log level (for example, only seeingERROR
messages if any, or taking outDEBUG
messages when needed). it also allows us to keep track of metrics down the road.How Has This Been Tested?
Screenshots (if appropriate):
Related Issues