Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.17.0 Thrift Error #1107

Open
ding1992 opened this issue Jun 30, 2021 · 4 comments
Open

0.17.0 Thrift Error #1107

ding1992 opened this issue Jun 30, 2021 · 4 comments

Comments

@ding1992
Copy link

Describe the bug
Code compatibility issue with thrift 0.13.0

To Reproduce
Is the issue reproducible?
Yes

Steps to reproduce the behavior:
go get go.uber.org/[email protected]

Expected behavior
No error

Actual behavior

../../../../pkg/mod/go.uber.org/[email protected]/internal/common/thrift_util.go:31:38: not enough arguments in call to thrift.NewTSerializer().Write
have (thrift.TStruct)
want (context.Context, thrift.TStruct)
../../../../pkg/mod/go.uber.org/[email protected]/internal/common/thrift_util.go:47:18: not enough arguments in call to v.Write
have (thrift.TProtocol)
want (context.Context, thrift.TProtocol)
../../../../pkg/mod/go.uber.org/[email protected]/internal/common/thrift_util.go:53:27: not enough arguments in call to t.Protocol.Flush
have ()
want (context.Context)
../../../../pkg/mod/go.uber.org/[email protected]/internal/common/thrift_util.go:57:28: not enough arguments in call to t.Transport.Flush
have ()
want (context.Context)
../../../../pkg/mod/go.uber.org/[email protected]/internal/common/thrift_util.go:67:39: not enough arguments in call to thrift.NewTDeserializer().Read
have (thrift.TStruct, []byte)
want (context.Context, thrift.TStruct, []byte)
../../../../pkg/mod/go.uber.org/[email protected]/internal/common/thrift_util.go:79:21: not enough arguments in call to ts[i].Read
have (thrift.TProtocol)
want (context.Context, thrift.TProtocol)

@KScaesar
Copy link

I have the same problem
How do I solve this?

My version
go version go1.16.4 linux/amd64

@longquanzheng
Copy link
Collaborator

See @Groxx comment #1129 (comment)

@longquanzheng
Copy link
Collaborator

Make sure you use the right version of thrift

Thrift 0.9.3 (use homebrew or distribution)

@longquanzheng
Copy link
Collaborator

You can pin the thrift version: like this: https://github.com/uber/cadence/blob/d3d06825adcf11c20ec3fc58e329f1d9560bb729/go.mod#L92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants