Introduce DisableStrictNonDeterminismCheck worker option #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Groxx
reviewed
Nov 3, 2023
Groxx
reviewed
Nov 6, 2023
Groxx
reviewed
Nov 6, 2023
Groxx
reviewed
Nov 6, 2023
Groxx
reviewed
Nov 6, 2023
Groxx
reviewed
Nov 6, 2023
Groxx
reviewed
Nov 6, 2023
Groxx
reviewed
Nov 6, 2023
Groxx
reviewed
Nov 6, 2023
|
since we'll be enabling this by default, we probably want this flag to be reversed, yea? doing it gradually could work too (say over a couple versions), but that'd still need to change the name or type of the field, which we essentially can't do. |
Synced offline on this and agreed to enable by default so reversing the bool option to disable when needed. |
taylanisikdemir
force-pushed
the
taylan/strict_nondeterminism_option
branch
from
80e6cbf
to
f6ec95c
Compare
taylanisikdemir
changed the title
Groxx
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Adding a new option to be able to toggle non-determinism false positives fix in #1281.
Why?
The strict non-determinism checks in #1281 may cause some existing workflows to fail due to the existing buggy non-determinism checks in task handling loop. So exposing this option to disable the strict non-determinism if needed.
How did you test it?
#1281 will be rebased with this change and testing will be done there.
Potential risks
N/A