Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override idls module to submodule to simplify idl update flow #1358

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Override idls module to submodule to simplify idl update flow #1358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
238b1e0
Override idls module to submodule to simplify idl update flow
3vilhamster Jul 16, 2024
bf3a367
add submodule update to the commands
3vilhamster Jul 16, 2024
49bc2fd
add submodules to the checkout
3vilhamster Jul 16, 2024
ef9b405
trying to fix submodules
3vilhamster Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .buildkite/pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ steps:
- <<: *commandContainer
command:
- |-
git submodule update --init
make unit_test
.buildkite/scripts/gen_coverage_metadata.sh .build/metadata.txt
- docker-compose#v3.0.0:
Expand All @@ -72,6 +73,7 @@ steps:
- <<: *commandContainer
command:
- |-
git submodule update --init
./scripts/golint.sh
- docker-compose#v3.0.0:
run: unit-test
Expand All @@ -92,6 +94,7 @@ steps:
- <<: *commandContainer
command:
- |-
git submodule update --init
make integ_test_sticky_off
- docker-compose#v3.0.0:
run: integ-test
Expand All @@ -112,6 +115,7 @@ steps:
- <<: *commandContainer
command:
- |-
git submodule update --init
make integ_test_sticky_on
- docker-compose#v3.0.0:
run: integ-test
Expand All @@ -132,6 +136,7 @@ steps:
- <<: *commandContainer
command:
- |-
git submodule update --init
make integ_test_grpc
- docker-compose#v3.0.0:
run: integ-test-grpc
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/codecov.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ jobs:
- name: Checkout
uses: actions/checkout@v4
with:
submodules: 'true'
fetch-depth: 0

- name: Set up Go
Expand Down
1 change: 1 addition & 0 deletions docker/buildkite/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ RUN mkdir -p /go/src/go.uber.org/cadence
WORKDIR /go/src/go.uber.org/cadence

ADD go.mod go.sum /go/src/go.uber.org/cadence/
ADD idls /go/src/go.uber.org/cadence/idls

# allow git-status and similar to work
RUN git config --global --add safe.directory /go/src/go.uber.org/cadence
Expand Down
2 changes: 2 additions & 0 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,3 +114,5 @@ retract (
v0.3.0 // Published accidentally
v0.2.0 // Published accidentally
)

replace github.com/uber/cadence-idl => ./idls
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replaces do not work for anyone importing the client, so this only works for local developers

2 changes: 0 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,8 +203,6 @@ github.com/uber-go/mapdecode v1.0.0/go.mod h1:b5nP15FwXTgpjTjeA9A2uTHXV5UJCl4arw
github.com/uber-go/tally v3.3.12+incompatible/go.mod h1:YDTIBxdXyOU/sCWilKB4bgyufu1cEi0jdVnRdxvjnmU=
github.com/uber-go/tally v3.3.15+incompatible h1:9hLSgNBP28CjIaDmAuRTq9qV+UZY+9PcvAkXO4nNMwg=
github.com/uber-go/tally v3.3.15+incompatible/go.mod h1:YDTIBxdXyOU/sCWilKB4bgyufu1cEi0jdVnRdxvjnmU=
github.com/uber/cadence-idl v0.0.0-20240416202333-83d5cae7fc51 h1:gAdDymipzIzh7PTPAW7DjFT2BOEwY7hwC0COsZIulsI=
github.com/uber/cadence-idl v0.0.0-20240416202333-83d5cae7fc51/go.mod h1:oyUK7GCNCRHCCyWyzifSzXpVrRYVBbAMHAzF5dXiKws=
github.com/uber/jaeger-client-go v2.22.1+incompatible h1:NHcubEkVbahf9t3p75TOCR83gdUHXjRJvjoBh1yACsM=
github.com/uber/jaeger-client-go v2.22.1+incompatible/go.mod h1:WVhlPFC8FDjOFMMWRy2pZqQJSXxYSwNYOkTr/Z6d3Kk=
github.com/uber/jaeger-lib v2.2.0+incompatible/go.mod h1:ComeNDZlWwrWnDv8aPp0Ba6+uUTzImX/AauajbLI56U=
Expand Down
Loading