Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support for wasi #1121

Merged
merged 3 commits into from
Sep 28, 2023
Merged

adding support for wasi #1121

merged 3 commits into from
Sep 28, 2023

Conversation

maceip
Copy link
Contributor

@maceip maceip commented Sep 27, 2023

go 1.21 added wasi preview 1

go 1.21 added wasi preview 1
@CLAassistant
Copy link

CLAassistant commented Sep 27, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@sywhang sywhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

I think it makes more sense for this to be a build tag change in app_wasm.go rather than adding a whole file with the exact same content?

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #1121 (c7e270e) into master (580de58) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1121   +/-   ##
=======================================
  Coverage   98.80%   98.80%           
=======================================
  Files          36       36           
  Lines        3088     3088           
=======================================
  Hits         3051     3051           
  Misses         30       30           
  Partials        7        7           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sywhang sywhang merged commit f594306 into uber-go:master Sep 28, 2023
7 checks passed
@maceip maceip deleted the wasi branch September 29, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants