adding support for wasi #1121
Merged
adding support for wasi #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go 1.21 added wasi preview 1
|
|
sywhang
reviewed
Sep 27, 2023
There was a problem hiding this comment.
Thanks for the PR.
I think it makes more sense for this to be a build tag change in app_wasm.go rather than adding a whole file with the exact same content?
Codecov Report
@@ Coverage Diff @@
## master #1121 +/- ##
=======================================
Coverage 98.80% 98.80%
=======================================
Files 36 36
Lines 3088 3088
=======================================
Hits 3051 3051
Misses 30 30
Partials 7 7 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sywhang
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go 1.21 added wasi preview 1