feat(fxtest): Add WithTestLogger option #1159
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fxtest.New has this really nice behavior where by default,
it uses the
testing.TB
as the destination for log output.Unfortunately, fxtest is not good for testing failure cases
because it fails the test if the container failed.
So the expectation there is to use
fx.New(..)
which, by default,logs to stderr.
This can be addressed by using the
fx.WithLogger
optionin combination with
fxtest.NewTestLogger
,but it ends up being a mouthful:
This PR is a proposal and implementation of a new
fxtest.WithTestLogger
option that shortens the above to:As an example, a couple tests in Fx itself become more readable
with this new API.