go.uber.org/atomic => sync/atomic #1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's only one use of go.uber.org/atomic in the codebase, and it's satisfiable with sync/atomic. This switches to sync/atomic, and drops the go.uber.org/atomic dependency completely.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1161 +/- ##
=======================================
Coverage 98.78% 98.78%
=======================================
Files 30 30
Lines 3057 3057
=======================================
Hits 3020 3020
Misses 30 30
Partials 7 7 ☔ View full report in Codecov by Sentry. |
sywhang
approved these changes
Feb 15, 2024
r-hang
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's only one use of go.uber.org/atomic in the codebase,
and it's satisfiable with sync/atomic.
This switches to sync/atomic,
and drops the go.uber.org/atomic dependency completely.