Fix golangci-lint installation step in CI #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following uber-go/zap#1424 as an example, fix CI to use `--help` flag since `--version` is no longer accepted. (example issue: https://github.com/uber-go/fx/actions/runs/8469190208/job/23203935028?pr=1182)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1185 +/- ##
=========================================
Coverage ? 98.73%
=========================================
Files ? 31
Lines ? 2851
Branches ? 0
=========================================
Hits ? 2815
Misses ? 29
Partials ? 7 ☔ View full report in Codecov by Sentry. |
sywhang
approved these changes
Apr 2, 2024
JacobOaks
added a commit
to JacobOaks/sally
that referenced
this pull request
Apr 29, 2024
Following uber-go/zap#1424 and uber-go/fx#1185 as examples. `--version` is no longer accepted. Use `--help` instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following uber-go/zap#1424 as an example, fix CI to use
--helpflag since--versionis no longer accepted.(example issue: https://github.com/uber-go/fx/actions/runs/8469190208/job/23203935028?pr=1182)