Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify example "Export boundary functions" #1221

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Clarify example "Export boundary functions" #1221

wants to merge 1 commit into from

Commits on Jun 27, 2024

  1. Update modules.md 

    I don't think the example follows good coding conventions. If `Config` is supposed to be a parameter object, it should be named `Params` since the constructor is called `New(...)` and needs defined `fx.In` within. If it is not meant to be an parameter object, I think passing `Params` into the constructor without defining that in the example is confusing.
    @JamesSlocumIH
    JamesSlocumIH committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    12d3ec0 View commit details
    Browse the repository at this point in the history