Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Merge intro into index #1234

Merged
merged 4 commits into from
Aug 27, 2024
Merged

Conversation

abhinav
Copy link
Collaborator

@abhinav abhinav commented Aug 27, 2024

The intro.md page and the index.md page were very similar in content.
Merge the two together, further polish the content,
and redirect the old intro.md page to index.md.

The intro.md page and the index.md page were very similar in content.
Merge the two together, further polish the content,
and redirect the old intro.md page to index.md.
@abhinav
Copy link
Collaborator Author

abhinav commented Aug 27, 2024

Preview:
image

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.42%. Comparing base (27eba7c) to head (7cef53d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1234   +/-   ##
=======================================
  Coverage   98.42%   98.42%           
=======================================
  Files          35       35           
  Lines        2918     2918           
=======================================
  Hits         2872     2872           
  Misses         38       38           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@JacobOaks JacobOaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 two suggestions that I feel make the prose flow better, but LGTM.

docs/src/index.md Outdated Show resolved Hide resolved
docs/src/index.md Outdated Show resolved Hide resolved
@abhinav abhinav merged commit 99eee83 into uber-go:master Aug 27, 2024
12 checks passed
@abhinav abhinav deleted the abg/doc-no-intro branch August 27, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants