Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timeout report generation race #816

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix timeout report generation race #816

wants to merge 1 commit into from

Commits on Nov 20, 2021

  1. Fix timeout report generation race 

    When fx is run with a very short timeout, it's possible for the
timeout error message to be in a bad format "OnStart hook added by  failed"
where the name of the OnStart hook's caller hasn't been recorded
before the context times out.

This fixes the error message generation to not rely on the OnStart hook's
caller always being known to fix this race.

Fixes uber-go#815
    @sywhang
    sywhang committed Nov 20, 2021
    Configuration menu
    Copy the full SHA
    1a810d4 View commit details
    Browse the repository at this point in the history