Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add TLS configuration #74

Merged
merged 1 commit into from
May 3, 2019
Merged

Add TLS configuration #74

merged 1 commit into from
May 3, 2019

Conversation

wxing1292
Copy link
Contributor

Cadence has external customer who use SSL / TLS for Kafka auth.

Can we accept this PR or #55?

@codecov
Copy link

codecov bot commented May 1, 2019

Codecov Report

Merging #74 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   73.75%   73.79%   +0.03%     
==========================================
  Files          21       21              
  Lines        1349     1351       +2     
==========================================
+ Hits          995      997       +2     
  Misses        315      315              
  Partials       39       39
Impacted Files Coverage Δ
internal/consumer/options.go 100% <ø> (ø) ⬆️
kafka/config.go 14.54% <ø> (ø) ⬆️
consumerBuilder.go 84.01% <100%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2f0d43...ae3303f. Read the comment docs.

@wxing1292 wxing1292 requested review from georgeteo and mmchen May 1, 2019 20:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants