Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add direct coverage to zap.Any #1309

Merged
merged 1 commit into from
Jul 30, 2023
Merged

Add direct coverage to zap.Any #1309

merged 1 commit into from
Jul 30, 2023

Conversation

rabbbit
Copy link
Contributor

@rabbbit rabbbit commented Jul 30, 2023

Practically, the cases added are today covered by the tests for strongly typed functions, but are missing if someone was to do a refactoring like #1305 or #1307.

More theoretically, since zap.Any is an external interface, IMO it makes sense to test it separately too.

Practically, the cases added are today covered by the tests for strongly
typed functions, but are missing if someone was to do a refactoring like #1305
or #1307.

More theoretically, since `zap.Any` is an external interface, IMO it
makes sense to test it separately too.
@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Merging #1309 (d0c8c2d) into master (1310691) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1309   +/-   ##
=======================================
  Coverage   98.08%   98.08%           
=======================================
  Files          50       50           
  Lines        3242     3242           
=======================================
  Hits         3180     3180           
  Misses         53       53           
  Partials        9        9           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@abhinav abhinav merged commit 8db347b into master Jul 30, 2023
5 checks passed
@abhinav abhinav deleted the pawel/any-coverage branch July 30, 2023 17:14
rabbbit added a commit that referenced this pull request Aug 2, 2023
Practically, the cases added are today covered by the tests for strongly
typed functions, but are missing if someone was to do a refactoring like
#1305 or #1307.

More theoretically, since `zap.Any` is an external interface, IMO it
makes sense to test it separately too.
sywhang pushed a commit that referenced this pull request Aug 2, 2023
Practically, the cases added are today covered by the tests for strongly
typed functions, but are missing if someone was to do a refactoring like
#1305 or #1307.

More theoretically, since `zap.Any` is an external interface, IMO it
makes sense to test it separately too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants