Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Go 1.18 build tags #1322

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Remove Go 1.18 build tags #1322

merged 1 commit into from
Aug 16, 2023

Conversation

abhinav
Copy link
Collaborator

@abhinav abhinav commented Aug 16, 2023

Go 1.19 has been the minimum required version
since Go 1.20 was released.
With the release of Go 1.21, even Go 1.19 is unsupported.
There's no reason specialize for versions before Go 1.18 anymore.

This deletes the Go 1.18 build-tagged files
and merges their contents into their siblings.

Go 1.19 has been the minimum required version
since Go 1.20 was released.
With the release of Go 1.21, even Go 1.19 is unsupported.
There's no reason specialize for versions before Go 1.18 anymore.

This deletes the Go 1.18 build-tagged files
and merges their contents into their siblings.
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #1322 (7ae9801) into master (fcfd368) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1322   +/-   ##
=======================================
  Coverage   97.77%   97.77%           
=======================================
  Files          52       51    -1     
  Lines        3366     3366           
=======================================
  Hits         3291     3291           
  Misses         65       65           
  Partials       10       10           
Files Changed Coverage Δ
array.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@abhinav abhinav enabled auto-merge (squash) August 16, 2023 19:14
@abhinav abhinav merged commit 613271a into master Aug 16, 2023
7 checks passed
@abhinav abhinav deleted the drop-go118 branch August 16, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants