zapcore: add warning as Level

[florianl]

Some packages set their value for WarnLevel to "warning". For easier integration add "warning" as accepted WarnLevel.

Example for a package that is using "warning":
https://github.com/sirupsen/logrus/blob/dd1b4c2e81afc5c255f216a722b012ed26be57df/logrus.go#L68

[CLAassistant]

All committers have signed the CLA.

[florianl]

Friendly ping for feedback to @abhinav or @JacobOaks .
Thanks in advance 🙏

[r-hang]

Hey @florianl, I think this change incurs some technical debt for a small amount of flexibility. The current level MarshalText logic is simplified because there is either a capitalized or lower case representation of the each level, where the level is represented in a consistent tense.

From my perspective, the special check case in level_test.go makes the level test code a bit more difficult to main.

[florianl]

Hey @r-hang thanks for the feedback!
I agree with you, that current level MarshalText logic is simplified and should stay that way.

There are cases where this packages is expected to handle input, that is generated from other packages, that are using the same levels, but slightly different level text - warning instead of warn. Currently this package is not able to pick up these slightly differences. In such cases where this package is expected to handle input with level warning, it will ignore this level, and will instead use level=info - which is not correct.
The intention of this PR is, that this package is able to handle input that originates from other sources and transparently uses the correct level.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.70%. Comparing base (b15585b) to head (cb50e12).
Report is 7 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1429   +/-   ##
=======================================
  Coverage   98.69%   98.70%           
=======================================
  Files          53       53           
  Lines        2997     3014   +17     
=======================================
+ Hits         2958     2975   +17     
  Misses         31       31           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[florianl]

@r-hang what do you think about having a dedicated test for unmarshaling warning rather mixing it with the existing TestLevelText? This should decrease the maintenance level in the test you have mentioned.

[florianl]

@abhinav or @JacobOaks or @r-hang with 126ea63 I have moved the test to guarantee compatability to a dedicated sub test. Please let me know, if this works for you.

[florianl]

friendly ping to @abhinav or @JacobOaks or @r-hang - do you have some feedback?

[r-hang]

Makes sense to me @florianl! Thanks for helping keep our tests more maintainable and sorry for the delay.