Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codecov: Use non-environment option #1447

Merged
merged 1 commit into from
Jun 12, 2024
Merged

codecov: Use non-environment option #1447

merged 1 commit into from
Jun 12, 2024

Conversation

r-hang
Copy link
Contributor

@r-hang r-hang commented Jun 12, 2024

codecov jobs have been failing recently.

The error we're seeing with verbose true is

debug - 2024-06-12 19:18:58,188 -- Starting create commit process --- {"commit_sha": "60547051d2c7a282f81ee9c7cb4c2547c0640e40", "parent_sha": null, "pr": "1435", "branch": "dependabot/github_actions/golangci/golangci-lint-action-6", "slug": "uber-go/zap", "token": null, "service": "github", "enterprise_url": null}
Error: Codecov token not found. Please provide Codecov token with -t flag.
Warning: Codecov: Failed to properly create commit: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1

ref: https://github.com/uber-go/zap/actions/runs/9488445442/job/26147390272#step:6:58

From the docs there are multiple valid ways to specify the coverage upload token https://github.com/codecov/codecov-action

Since we're using the environment variable approach and we're still getting an error that the token is not provided, let's try the with token option.

codecov jobs have been failing recently.

The error we're seeing with verbose true is
```
debug - 2024-06-12 19:18:58,188 -- Starting create commit process --- {"commit_sha": "60547051d2c7a282f81ee9c7cb4c2547c0640e40", "parent_sha": null, "pr": "1435", "branch": "dependabot/github_actions/golangci/golangci-lint-action-6", "slug": "uber-go/zap", "token": null, "service": "github", "enterprise_url": null}
Error: Codecov token not found. Please provide Codecov token with -t flag.
Warning: Codecov: Failed to properly create commit: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
```

ref: https://github.com/uber-go/zap/actions/runs/9488445442/job/26147390272#step:6:58

From the docs there are multiple valid ways to specify the coverage
upload token https://github.com/codecov/codecov-action

Since we're using the environment variable approach and we're still
getting an error that the token is not provided, let's try the with token
option.
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.70%. Comparing base (0c79c08) to head (1705a71).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1447   +/-   ##
=======================================
  Coverage   98.70%   98.70%           
=======================================
  Files          53       53           
  Lines        3014     3014           
=======================================
  Hits         2975     2975           
  Misses         31       31           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sywhang sywhang merged commit a1ac9d2 into master Jun 12, 2024
8 checks passed
@sywhang sywhang deleted the rhang/fix-code-cov branch June 12, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants