zaptest: add ability to filter observer logs by logger name #1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful for assertions on logs in a particular named path, currently
this is only possible through calls to Filter but it is more verbose.
Added a FilterLoggerName function that plays nicely with the other filters:
zapLogs.FilterLoggerName("my.logger").FilterMessage("hello")
Signed-off-by: Mauri de Souza Meneguzzo <[email protected]>
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1452 +/- ##
==========================================
- Coverage 98.70% 98.64% -0.07%
==========================================
Files 53 53
Lines 3014 3018 +4
==========================================
+ Hits 2975 2977 +2
- Misses 31 32 +1
- Partials 8 9 +1 ☔ View full report in Codecov by Sentry. |
sywhang
reviewed
Jul 22, 2024
sywhang
reviewed
Jul 22, 2024
sywhang
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for assertions on logs in a particular named path, currently this is only possible through calls to Filter but it is more verbose.
Added a FilterLoggerName function that plays nicely with the other filters: