Upgrade grpc in zapgrc test package & bump go version #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dependabot PR uber-go#1376 fails to bump grpc due to conflict with go1.16 (ref: uber-go#1473). Bump go version by one so go mod tidy is happy in the test package with the grpc upgrade.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1478 +/- ##
=======================================
Coverage 98.59% 98.59%
=======================================
Files 53 53
Lines 3562 3562
=======================================
Hits 3512 3512
Misses 42 42
Partials 8 8 ☔ View full report in Codecov by Sentry. |
sywhang
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependabot PR #1376 fails to bump grpc due to conflict with go1.16 (ref: #1473).
Bump go version by one so go mod tidy is happy in the test package with the grpc upgrade.