Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT LAND] @EnsuresNonNullIf benchmarking only #1046

Closed
wants to merge 53 commits into from
Closed

[DO NOT LAND] @EnsuresNonNullIf benchmarking only #1046

wants to merge 53 commits into from

Conversation

msridhar
Copy link
Collaborator

@msridhar msridhar commented Sep 30, 2024 •
edited
Loading

No description provided.

mauricioaniche and others added 30 commits September 24, 2024 22:56
@mauricioaniche
First draft of @EnsuresNonNullIf
60c09cd
@mauricioaniche
Merge branch 'master' into ensures-non-null-if
dfcfb04
@mauricioaniche
Improve validation of the semantics of the EnsuresNonNullIfHandler
c674bf9
@mauricioaniche
More tests
c511a79
@mauricioaniche
Improve docs
9eac416
@mauricioaniche
Validate post-conditions in child classes
38d6d88
@mauricioaniche
A few more tests
c2a5dc2
@mauricioaniche
Tests cleanup
17b9173
@mauricioaniche
Fix error message in FieldContractUtils
e4ab9ba
@mauricioaniche
Fix error message in FieldContractUtils again
9cbcf4e
@mauricioaniche
Add trueIfNonNull to invert the result of the EnsuresNonNullIf method
d044fae
@mauricioaniche
Throw exception instead of returning default value in exceptional case
d700ee3
@mauricioaniche
Rename variable
6842120
@mauricioaniche
Fix nullability issues in my code
df1293f
@mauricioaniche
One more test
1bf794c
@mauricioaniche
Move ignored tests to the bottom
c471082
@msridhar
add TODO
6ebac11
@mauricioaniche
Make use of internal state to get the enclosing method of a return tree
3b27dae
@mauricioaniche
Improvements here and there
4aa9ed0
@mauricioaniche
New approach
c0a70ac
@mauricioaniche
Code review feedback
5f2ad31
@mauricioaniche
Nit on javadoc
3ad3944
@mauricioaniche
Nit in comments
3afb836
@mauricioaniche
Put class back to original state to reduce changes in PR
de81671
@mauricioaniche
Got it working
92b3a77
@mauricioaniche
Cleaning up the doc and more docs
04a7d42
@mauricioaniche
Fix clean up
ee32c48
@mauricioaniche
More fixes
81b1edc
@mauricioaniche
Rename trueIfNonNull to result and make it compulsory, to match Check…
fbd05a7 
…erFramework
@mauricioaniche
More cleanups
b1faf00
mauricioaniche and others added 23 commits September 29, 2024 11:16
@mauricioaniche
Handle missing case where allFieldsInPathAreVerified is false and eva…
0f71fde 
…luatesToLiteral
@mauricioaniche
nit comment
880ae42
@mauricioaniche
one more test
f478ac4
@mauricioaniche
one more test
d53958b
@mauricioaniche
FIX typo name of the test
13b0cca
@mauricioaniche
FIX typo name of the test
5d8157d
@mauricioaniche
one more test
2623bfa
@mauricioaniche
Fix nullaway issues in nullaway
1b1967c
@mauricioaniche
JSpecify annotation
80ef2ca
@mauricioaniche
small refactoring; fix compilation
5428602
@mauricioaniche
Use elseStore when result is set to false
ca7a54a
@mauricioaniche
Set return default value to true again
bb139df
@mauricioaniche
Improve tests
f23a8d4
@mauricioaniche
test for error message when result=false
45907e1
@mauricioaniche
Return true in case body is null just like existing EnsureNonNull han…
7a3d075 
…dler
@mauricioaniche
simplify error message
3c7295e
@mauricioaniche
Broken test
2bbbac2
@mauricioaniche
Fix issue when return=false and method returns boolean
ea10969
@msridhar
Let's not use an Optional here. Since we check the code with NullAway…
3cb7d51 
…, using null should be fine
@mauricioaniche
No need to report when all paths are verified but return is wrong
56a0984
@msridhar
minor comment tweak
f98fb3c
@msridhar
simplify dataflow update logic
fa7728e
@msridhar
comments
1c5610c
@msridhar msridhar closed this Oct 2, 2024
@msridhar msridhar deleted the ensures-non-null-if branch October 2, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
run-benchmarks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msridhar @mauricioaniche