Implement matching API to allow updating task list partition config #6472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaddoll
requested review from
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Shaddoll
force-pushed
the
update
branch
3 times, most recently
from
b69e487
to
4f6947d
Compare
Shaddoll
changed the title
Shaddoll
force-pushed
the
update
branch
4 times, most recently
from
3bc2459
to
8cd0c7c
Compare
davidporter-id-au
approved these changes
Nov 8, 2024
| domainID := request.DomainUUID | ||
| taskListName := request.TaskList.GetName() | ||
| taskListKind := request.TaskList.GetKind() | ||
| taskListType := persistence.TaskListTypeDecision |
There was a problem hiding this comment.
Nit: this is a little confusing to read to default like this, I'd suggest setting it to an zero value and switch below rather than defaulting
| defer sw.Stop() | ||
|
|
||
| if ok := h.userRateLimiter.Allow(quotas.Info{Domain: domainName}); !ok { | ||
| return nil, hCtx.handleErr(errMatchingHostThrottle) |
There was a problem hiding this comment.
Nit: a rate-limit event seems unlikely and probably worthy of a log
| if err != nil { | ||
| var e *types.EntityNotExistsError | ||
| if !errors.As(err, &e) { | ||
| c.Stop() |
There was a problem hiding this comment.
under what conditions would this occur? Could you add a comment if there's forseeable ones?
| c.partitionConfigLock.RUnlock() | ||
| return | ||
| c.logger.Debug("get task list partition config from db", tag.Dynamic("root-partition", c.taskListID.GetRoot()), tag.Dynamic("config", config)) |
There was a problem hiding this comment.
the log key config may conflict with other log structs using the same key in search indices and will result in the entire log-line being dropped. I'd just make it more unique with a name like tasklist-partition-config to avoid this.
davidporter-id-au
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed Description
Define and implement new grpc APIs for matching:
Impact Analysis
Testing Plan
Rollout Plan
This PR introduces new matching API allowing us to Update and Refresh task list partition config which is stored in database. We'll have another PR exposing these endpoints in frontend, create CLI command for these endpoints and have integration tests covering this.