Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use language names #688

Merged
merged 6 commits into from
Sep 3, 2024
Merged

Use language names #688

merged 6 commits into from
Sep 3, 2024

Conversation

stefanheule
Copy link
Collaborator

No description provided.

yuxincs
yuxincs approved these changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@yuxincs yuxincs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two questions due to my unfamiliarity with the codebase :)

But stamping in case you think it is actually not a problem

polyglot_piranha.pyi Show resolved Hide resolved
src/models/default_configs.rs Show resolved Hide resolved
@stefanheule
Copy link
Collaborator Author

Discussed offline.

@stefanheule stefanheule merged commit 2d495d6 into master Sep 3, 2024
3 of 4 checks passed
@stefanheule stefanheule deleted the langs branch September 3, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieltrt danieltrt danieltrt left review comments

@yuxincs yuxincs yuxincs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefanheule @yuxincs @danieltrt