-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runwhile support (limited) #84
base: master
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
Added description of the changes
Add TimeTorque driver
timetorque driver
timetorque driver
for more information, see https://pre-commit.ci
Optimized the code
for more information, see https://pre-commit.ci
Waiting for a reply from colleagues. But by quick Googling, there are a few common scenarios that I think should be implemented:
I think we should have a parameter for the time limit, comparison (like > or <) and number. The question is should we have separate parameters for each magnetization component or just pass the name.
|
I tried to separate it into two pull requests as asked. This is the proposed change for RunWhile support.
I personally also don't have much experience with RunWhile - I'll check with some of my colleagues for use cases. For now I suggest introducing the most widely used scenarios and letting the users pass other conditions directly as string.