This repository has been archived by the owner on Aug 29, 2024. It is now read-only.
fix: lower than and greater than characters are escaped #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x4007
reviewed
May 27, 2024
|
@0x4007 So I managed to run it locally, and this is the result I get: |
|
The problem I have with this is it appears as though you rendered it on a standalone HTML page, but I want to know how GitHub comments renders it before we accept the pull. Perhaps it would be simple to just run this on your own bot instance and see how the comment appears? |
|
@0x4007 Ran against the problematic issue, results here: |
0x4007
approved these changes
May 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid being interpreted,
<and>are escaped.Related issue: ubiquity/work.ubq.fi#47 (comment)