-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
leaderboard init #1
base: development
Are you sure you want to change the base?
Conversation
build/esbuild-build.ts
Outdated
}, | ||
outdir: "static/dist", | ||
define: createEnvDefines(["SUPABASE_URL", "SUPABASE_ANON_KEY"], { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This threw the error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know the format had changed. Is this change across all repos?
Did this stagnate? If it's because of env I could give you a little push as it seems you are really close to completion. |
Good idea to take projects over if they stop yes |
This is held back because the DB does not have all of the permits in order to generate a leaderboard which was the agreed upon approach as opposed to a cron job that would populate a repo json. I have had a PR awaiting review for months that is the requirement for this to progress ubiquity/.github#112. I seeded my db with a backup of the official instance although this was months ago when I saw it through to completion. Afaik the permit storage is broken and has been for months so newer permits may not even be getting populated right now. I can't find the comment but @gentlementlegen you mentioned it before I'm certain.
Please feel free to review ubiquity/.github#112 so that this can move forward if you like zug or get involved in improving the refactoring as it has a lot of weak points Dune being a blatant one ofc, happy to dual-assign and collab if need be or whatever, thanks. |
@Keyrxng yes there is a ticket on that regard: ubiquity-os-marketplace/text-conversation-rewards#152 |
I could merge this and just use the static data that I was told not to use previously, would that make sense in terms of being able to close this out or should we wait until ubiquity/.github#112? @0x4007 @rndquu |
I understood that, I believe you should wait will need to redo it anyway if you push. |
The consensus is typically not to wait and to push forward if possible, this has been stagnant for a long time and no clear sign that the required PR will be merged anytime soon so I'm offering solutions. If using the static data initially is acceptable as I first implemented, I can pull a fresh leaderboard and push this forward. Happy to do that given the green light to get things moving again. |
Resolves ubiquity/work.ubq.fi#45
Requires ubiquity/.github#109
It's still pulling from an old static repo file for the data at the moment.
You need to log in because of the above but once addressed there shouldn't be any need.