feat: Invalidate nonce #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rndquu
approved these changes
Feb 16, 2024
molecula451
requested changes
Feb 16, 2024
There was a problem hiding this comment.
looking good but it left to desire a bit, @gpylypchuk can you add a require() statement that checks the nonce has not been used?
sure! added :) |
molecula451
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
I'm accepting this PR because:
- rndquu already put eyes on it
- the PR meet the specification and conversational at the PR issue
- the user applied all the changes and meet the specification
- I tested locally and it invalidate the stuff
Last but not least:
- There might be other edges cases to improve the security of the invalidation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4 issue.