Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

chore: update and improve README.md #844

Merged
merged 38 commits into from
Nov 9, 2023

Conversation

molecula451
Copy link
Member

@molecula451 molecula451 commented Sep 27, 2023

@netlify
Copy link

netlify bot commented Sep 27, 2023

Deploy Preview for ubiquibot-staging ready!

Name Link
🔨 Latest commit be0af73
🔍 Latest deploy log https://app.netlify.com/sites/ubiquibot-staging/deploys/6539133aff7f750008b39e20
😎 Deploy Preview https://deploy-preview-844--ubiquibot-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@wannacfuture wannacfuture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to me. 👍

This will help new contributors who having issues running the bot.
@ubiquity/software-development Please take a look

@rndquu rndquu self-requested a review October 9, 2023 06:37
rndquu
rndquu previously approved these changes Oct 9, 2023
wannacfuture
wannacfuture previously approved these changes Oct 9, 2023
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@molecula451 molecula451 dismissed stale reviews from wannacfuture and rndquu via c1c24bb October 12, 2023 10:29
@molecula451 molecula451 marked this pull request as ready for review October 25, 2023 04:49
@molecula451
Copy link
Member Author

everyone check QA https://github.com/molecula451/ubiquibot/blob/update-readme/README.md

@molecula451
Copy link
Member Author

it looks like pavlovcik wants to also integrate the supabase migration thing #838 (comment) but! the supabase readme it's complete and i think a dev should be aware of this module at the repo and how to handle the inner stuff of supabase, e.g migrations what do you guys think? @rndquu @0xcodercrane @wannacfuture @whilefoo

@0x4007
Copy link
Member

0x4007 commented Oct 25, 2023

everyone check QA https://github.com/molecula451/ubiquibot/blob/update-readme/README.md

I skimmed this. It looks really substantial! Good work! I do not have time to test the set up right now but I expect that the other team members should try from A to Z to set up a new bot and follow that tutorial.

@wannacfuture
Copy link
Contributor

wannacfuture commented Oct 25, 2023

everyone check QA https://github.com/molecula451/ubiquibot/blob/update-readme/README.md

I skimmed this. It looks really substantial! Good work! I do not have time to test the set up right now but I expect that the other team members should try from A to Z to set up a new bot and follow that tutorial.

I have tried this readme(setting up the bot) and looks good to me. 👍

Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve based on @wannacfuture's review. However it would be appreciated if we could get at least one more before merging.

@molecula451
Copy link
Member Author

yeah i agree @rndquu @0xcodercrane

@molecula451
Copy link
Member Author

@0xcodercrane crane let's get an eagle eye on this one to help pavlovcik get it merge

@0x4007 0x4007 enabled auto-merge November 8, 2023 12:38
@0x4007
Copy link
Member

0x4007 commented Nov 8, 2023

@whilefoo when you approve this will automatically merge. Thanks everybody for your reviews!

@molecula451
Copy link
Member Author

@whilefoo your review it's important for everyone here

@0x4007 0x4007 merged commit c015fc7 into ubiquity:development Nov 9, 2023
8 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Readme for New Contributors
6 participants