-
Notifications
You must be signed in to change notification settings - Fork 61
feat: changed the migrations to reflect the new database schema #923
feat: changed the migrations to reflect the new database schema #923
Conversation
I don't know enough about migrations to understand this pull well enough. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why we even need this because this is old codebase but it looks just a DB dump and it's hard to read
It is a literal db dump as I didn't know myself what functions were written in the database. It is useful to get the exact same state as the current DB is now for local or self hosted dev purposes. Since we gonna have one DB per module it shall be irrelevant soon. |
Perhaps one KV per module instead |
@whilefoo I think it would be important to get this in because many newcomers do not have the schema migrations to work locally, and do not have access to the current production database. While I do understand your concern about cleanliness of the file, it is auto generated and I don't have much control over it, and there is no option to prettify the output, only options being documented here. |
Sorry, I didn't know you were waiting for me |
Resolves #919
Follows up PR ubiquity-os/ubiquity-os-kernel#33