Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

feat: changed the migrations to reflect the new database schema #923

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

gentlementlegen
Copy link
Member

Resolves #919

Follows up PR ubiquity-os/ubiquity-os-kernel#33

rndquu
rndquu previously approved these changes Mar 18, 2024
@0x4007 0x4007 removed their request for review March 20, 2024 09:32
@0x4007
Copy link
Member

0x4007 commented Mar 20, 2024

I don't know enough about migrations to understand this pull well enough.

Copy link
Collaborator

@whilefoo whilefoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why we even need this because this is old codebase but it looks just a DB dump and it's hard to read

supabase/migrations/20240313073422_init.sql Show resolved Hide resolved
supabase/migrations/20240313073422_init.sql Show resolved Hide resolved
supabase/migrations/20240313073422_init.sql Show resolved Hide resolved
supabase/migrations/20240313073422_init.sql Show resolved Hide resolved
supabase/migrations/20240313073422_init.sql Show resolved Hide resolved
supabase/migrations/20240313073422_init.sql Show resolved Hide resolved
@gentlementlegen
Copy link
Member Author

It is a literal db dump as I didn't know myself what functions were written in the database. It is useful to get the exact same state as the current DB is now for local or self hosted dev purposes. Since we gonna have one DB per module it shall be irrelevant soon.

@0x4007
Copy link
Member

0x4007 commented Mar 20, 2024

Since we gonna have one DB per module it shall be irrelevant soon.

Perhaps one KV per module instead

@gentlementlegen
Copy link
Member Author

@whilefoo I think it would be important to get this in because many newcomers do not have the schema migrations to work locally, and do not have access to the current production database. While I do understand your concern about cleanliness of the file, it is auto generated and I don't have much control over it, and there is no option to prettify the output, only options being documented here.

@whilefoo
Copy link
Collaborator

Sorry, I didn't know you were waiting for me

@whilefoo whilefoo enabled auto-merge April 11, 2024 14:28
@whilefoo whilefoo merged commit 0fde755 into ubiquity:development Apr 11, 2024
5 of 6 checks passed
@gentlementlegen gentlementlegen deleted the feat/new-db-migration branch April 11, 2024 14:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup RLS and CLS for supabase
4 participants